fix: removed the detail section because it's not helpful#4005
fix: removed the detail section because it's not helpful#4005
Conversation
Signed-off-by: Uroš Marolt <uros@marolt.me>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Pull request overview
This PR simplifies the integration results reporting Slack output by removing the per-error “detail/message” field from the error grouping and notification content, keeping the report focused on actionable summary information.
Changes:
- Removed the
messagefield from theIErrorGrouptype. - Updated the error-grouping SQL query to stop selecting/grouping by
r.error->>'message'. - Removed the “Detail” line from the Slack message formatting for error groups.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Uroš Marolt <uros@marolt.me>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: Uroš Marolt <uros@marolt.me>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f416fd4. Configure here.
Signed-off-by: Uroš Marolt <uros@marolt.me>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Note
Low Risk
Low risk: changes only error-reporting payload/Slack formatting and how error locations are computed from stack traces, without affecting core processing logic or data writes beyond stored error metadata.
Overview
Removes the per-error "detail"/
messagefield from the integration results Slack report and updates the aggregation query to group errors only byerrorMessage+location.Updates
data_sink_workererror recording to stop passing a hardcoded location/message and instead deriveerror.locationfrom the first relevant frame in the thrown error’s stack (extractLocationFromError), simplifying call sites and standardizing stored error metadata.Reviewed by Cursor Bugbot for commit b6ba6b0. Bugbot is set up for automated code reviews on this repo. Configure here.